Skip to content

Conversation

Alex-Sokolov
Copy link
Contributor

@Alex-Sokolov Alex-Sokolov commented May 1, 2017

README.md not translated. Seems it not used anywhere?

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@posva posva requested a review from simplesmiler May 1, 2017 22:40
@simplesmiler
Copy link
Member

@Alex-Sokolov in english version README.md appears to be used as the Introduction page (https://ssr.vuejs.org/en/). Unfortunately I can't not run the gitbook locally to check.

@Alex-Sokolov
Copy link
Contributor Author

@simplesmiler Thanks for notice! Translated README.md

@simplesmiler
Copy link
Member

@Alex-Sokolov sent review in form of PR, translation-gang#11
Other than that, translation looks good to me, good job! 👍

@Alex-Sokolov
Copy link
Contributor Author

@simplesmiler merged your PR :)

@Alex-Sokolov
Copy link
Contributor Author

@kazupon @posva ping :)

@posva posva merged commit e122f57 into vuejs:master May 6, 2017
@Alex-Sokolov
Copy link
Contributor Author

When it will be available online? :)

@Alex-Sokolov
Copy link
Contributor Author

@kazupon @posva who can publish online?)

@yyx990803
Copy link
Member

@Alex-Sokolov thanks for the contribution, please be patient and we will deploy when we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants